Don't override saved initial ranges on data-updating restyle calls [fixes #346]#351
Merged
Don't override saved initial ranges on data-updating restyle calls [fixes #346]#351
Conversation
- to more easily chain actions in click tests
- so that restyle calls that update that purge gd.calcdata don't update the 'initial' axis ranges. - save initial range even if gd._context settings are such that it won't get used (in case gd._context changes during the plot life cycle).
Contributor
|
Love the code:test ratio. 💃 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@mdtusz
A cheeky edge case discovered by @Jodana in #346 .